Skip to content

Use Boost::json in olp-cpp-sdk-dataservice-write#1680

Closed
rustam-gamidov-here wants to merge 2 commits intofeature_boost_jsonfrom
rga/ocmam-445-boost-to-write-common-includes
Closed

Use Boost::json in olp-cpp-sdk-dataservice-write#1680
rustam-gamidov-here wants to merge 2 commits intofeature_boost_jsonfrom
rga/ocmam-445-boost-to-write-common-includes

Conversation

@rustam-gamidov-here
Copy link
Collaborator

@rustam-gamidov-here rustam-gamidov-here commented Mar 10, 2026

Migrating from RapidJSON

Move json headers from core to internal location. Prevents exposing internal headers from being exposed.
Could be converted to OBJECTS or static lib if there's need with linking boost to it privately. Considered to be an improvement opportunity for future

Relates-To: OCMAM-445

Migrating from RapidJSON

Relates-To: OCMAM-445
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
Prevents exposing internal headers from being exposed.
Could be converted to OBJECTS or static lib if there's need with
linking boost to it privately. Considered to be an improvement
opportunity for future

Relates-To: OCMAM-445
Signed-off-by: Rustam Gamidov <ext-rustam.gamidov@here.com>
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 89.88764% with 27 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature_boost_json@9a5efa0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...e/src/generated/serializer/IndexInfoSerializer.cpp 66.67% 8 Missing and 2 partials ⚠️
...erated/serializer/UpdateIndexRequestSerializer.cpp 72.73% 7 Missing and 2 partials ⚠️
.../include/json_boost/serializer/SerializerWrapper.h 92.31% 0 Missing and 2 partials ⚠️
...src/generated/serializer/PublicationSerializer.cpp 90.91% 0 Missing and 2 partials ⚠️
internal/include/json_boost/parser/JsonParser.h 85.71% 1 Missing ⚠️
internal/include/json_boost/parser/ParserWrapper.h 96.30% 0 Missing and 1 partial ⚠️
...ite/src/generated/parser/VersionResponseParser.cpp 0.00% 1 Missing ⚠️
...nerated/serializer/PublishPartitionsSerializer.cpp 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             feature_boost_json    #1680   +/-   ##
=====================================================
  Coverage                      ?   80.49%           
=====================================================
  Files                         ?      354           
  Lines                         ?    14060           
  Branches                      ?     1523           
=====================================================
  Hits                          ?    11317           
  Misses                        ?     2125           
  Partials                      ?      618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rustam-gamidov-here
Copy link
Collaborator Author

closing in favour of #1681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant