Cleanup pom#1052
Open
hernanponcedeleon wants to merge 4 commits into
Open
Conversation
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
xeren
previously approved these changes
Jul 6, 2026
xeren
left a comment
xeren
left a comment
Collaborator
There was a problem hiding this comment.
Apparently, commons-cli stopped being used in SVCompRunner.java since #195. That same MR also removed the usage of commons-cli in Dartagnan.java, so it could be possible to also remove the dependency from dartagnan (in another MR).
pl.project13.maven remains a direct dependency of dartagnan.
LGTM
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
Owner
Author
|
Good catch Rene! I found a few more old dependencies, so I got rid of them too. |
Collaborator
|
EDIT: We surely use it. Why can we remove it from dartagnan's pom? Is it transitively included now? |
Owner
Author
|
Oops, I accidentally edit your comment rather than answer it.
I do not see it used anywhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.