[DRAFT] Fix warnings in native build#1053
Open
hernanponcedeleon wants to merge 2 commits into
Open
Conversation
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
Collaborator
|
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
Owner
Author
Can you try again? This one I am still trying to figure out what the problem is |
Collaborator
|
The warnings are gone. The only warnings I get now are The warnings about ANTLR grammars exist since forever. But I'm not sure about the first 4 one's. |
Owner
Author
Do you also get these in development?
I already fixed these in the |
Collaborator
yep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native build has currently these warnings about the libraries
The changes solve the problem on linux, but I assume we have the same issue on MacOS (@ThomasHaas can you check?) and windows (IIRC @xeren has a windows environment; can you check there?) and we also need to add the "provided scope" there, thus the DRAFT status