ACC-63: PostgreSQL-Quellenarchitektur und Develop-Preview - #20
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ergebnis
owners.id, ownergebundene Schlüssel und den unveränderten BrowservertragFinanceDataV1Develop- und Preview-Workflow
develop; Production bleibt aufmasterdevelopVerifikation
npm test: 237 Vitest-Tests und 11 Node-Tests erfolgreichnpm run lint: erfolgreichnpm run licenses:check: erfolgreichnpm run build: erfolgreich, kein Mock-Chunknpm run docs:check: ausschließlich die zwei bereits bestehenden Fehler wegen der fehlenden.env.example; keine neuen Doku-FehlerScope
ACC-63 enthält bewusst noch keine PostgreSQL-Migration, API-Umschaltung oder Editor-Implementierung. Diese folgen über ACC-71, ACC-29, ACC-66 und ACC-72.
Linear: https://linear.app/kiumu-app/issue/ACC-63/architektur-fur-den-quellenwechsel-festlegen-und-adr-0001-ersetzen
Greptile Summary
The PR establishes PostgreSQL as the future sole finance source, limits Google OAuth to identity after cutover, and clearly distinguishes that target architecture from the currently implemented Sheets flow.
developand documents the develop-to-master release workflow.Confidence Score: 5/5
The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking defects identified.
The preview mode is selected at build time, production remains on the real API path, and the architectural documentation consistently distinguishes the current implementation from the accepted target state.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Vite build starts] --> B{VERCEL_ENV or VITE_VERCEL_ENV} B -->|preview| C[Compile mock flag as true] B -->|production or absent| D[Compile mock flag as false] C --> E[Load anonymous mock finance API] D --> F[Use production finance API] E --> G[Vercel Preview] F --> H[Production bundle without mock chunk]Reviews (1): Last reviewed commit: "docs(architecture): define postgres sour..." | Re-trigger Greptile