Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1426 +/- ##
==========================================
+ Coverage 73.29% 73.99% +0.69%
==========================================
Files 116 118 +2
Lines 12804 13124 +320
==========================================
+ Hits 9385 9711 +326
+ Misses 2344 2325 -19
- Partials 1075 1088 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jooola
reviewed
May 29, 2026
jooola
left a comment
Member
There was a problem hiding this comment.
Did a first pass, looks good. It needs some more work though.
jooola
reviewed
Jun 5, 2026
phm07
marked this pull request as ready for review
June 5, 2026 11:35
jooola
reviewed
Jun 24, 2026
jooola
left a comment
Member
There was a problem hiding this comment.
A bunch of things to address and the tests are missing.
For the tests, please try to test fetching the 3 protocols (tcp, http, https).
jooola
force-pushed
the
load-balancer-service-data-source
branch
from
July 31, 2026 12:24
048720a to
e15ac4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a dedicated data source for Load Balancer Services. The
servicesfield in the original Load Balancer data source was not populated and is deprecated after this PR.Fixes #1413 and #1136