Add redirect-aware TLS inspection UI + Update KnownCTLogs.swift#22
Add redirect-aware TLS inspection UI + Update KnownCTLogs.swift#22hewigovens merged 2 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements support for multi-hop TLS inspections, allowing the application to capture and display certificate details for each step in a redirect chain. Key changes include the introduction of a TLSInspection model, updates to the TLSInspector to capture multiple trust events, and UI enhancements in both iOS and macOS to navigate between different "hops." The PR also streamlines local development by adding support for a project.local.yml configuration file for Xcode signing. Review feedback highlights a potential logic error in how TLS metadata is paired with transactions, performance considerations regarding the new view hierarchy in the macOS root view, and a minor suggestion for more idiomatic Swift syntax.
hewigovens
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d30b1eed3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Packages/InspectCore/Sources/Feature/Inspection/InspectionRootView.swift
Show resolved
Hide resolved
Packages/InspectCore/Sources/Feature/Inspection/InspectionChainAndRecentCards.swift
Show resolved
Hide resolved
hewigovens
force-pushed
the
codex/redirect-aware-tls-inspection
branch
from
d30b1ee to
d9939d0
Compare
hewigovens
force-pushed
the
codex/redirect-aware-tls-inspection
branch
from
d9939d0 to
20dde3d
Compare
- Fix fragile index-based trust/metrics pairing with host-based matching - Hybrid ZStack for macOS root view (state preservation + lazy Settings) - Add just lint/format commands, resolve swiftformat/swiftlint conflicts - Re-enable identifier_name and cyclomatic_complexity lint rules, fix violations - Fix all remaining lint warnings (zero warnings) - Add swiftlint --strict to CI pipeline - Consolidate local signing overrides to project.local.yml only - Remove TLS hop info from CertificateDetailView - Fix vertical centering in redirect rows - Fix stale selectedReportIndex when switching domains - Fix regular layout summary/security cards not reflecting selected hop - Regenerate CT logs: Data-keyed dictionary, tiled_logs support, filter retired - Widen macOS certificate detail panel for long chains - Bump to 2.5.2 (build 86)
hewigovens
force-pushed
the
codex/redirect-aware-tls-inspection
branch
from
20dde3d to
6d0a405
Compare
1 participant
What changed
This PR adds redirect-aware manual TLS inspection while keeping
TLSInspectionReportas the single host/single chain model used by monitor history and shared report flows.It also updates the inspection and certificate UIs to let users switch between redirect hops cleanly, and includes the local XcodeGen override path so automatic signing can be kept outside the shared project config.
Other changes include lint and format