fix: surface output.postProcess execution errors#3683
Conversation
|
|
|
Reviewed PR #3683 — it's a WIP draft with zero code changes (the only commit is an empty "Initial plan" commit). No code to review yet; will re-review once implementation commits are pushed. |
🦋 Changeset detectedLatest commit: df406de The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
output.postProcess execution errors
|
@copilot avoid duplicating hard-coded message string for non-zero status codes, use |
Fixes issues related to surfacing postprocess errors in the output.
|
Reviewed PR #3683. The core error detection logic is correct and tests are thorough. Flagged two issues: (1) throwing plain Task list (4/4 completed)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3683 +/- ##
==========================================
+ Coverage 39.39% 39.47% +0.07%
==========================================
Files 520 521 +1
Lines 19279 19299 +20
Branches 5708 5722 +14
==========================================
+ Hits 7595 7618 +23
+ Misses 9445 9442 -3
Partials 2239 2239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
TL;DR — Key changes
Summary | 3 files | 4 commits | base: Error handling for post-processor execution
The fix captures the
|
There was a problem hiding this comment.
The error detection logic is correct and the tests are thorough. Two issues worth addressing — one impacts user experience significantly, the other is a minor edge case.
|
@pullfrog implement your feedback. Also have a look at the failing CI, seems there was another bug lurking in the postprocessor implementation. Can you figure out how to fix that too? |
|
Addressed all three review comments and fixed the CI failure. The review feedback (use Task list (6/6 completed)
|

postprocessOutputinpackages/shared/src/config/output/postprocess.tsto check result fromsync()and throw meaningful errors when:result.erroris set (e.g., ENOENT when command is not found in PATH)result.statusis non-zero (command exited with failure), including stderr in the messageletto avoid duplicating the base message stringpackages/shared/src/config/output/__tests__/postprocess.test.tscovering the new error-handling behavior (10 new tests, all passing)