Conversation
|
|
|
Reviewed PR #3684. Found two minor issues in Task list (3/3 completed)
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
TL;DR — Adds documentation for the Key changes
Summary | 9 files | 1 commit | base: Vite plugin documentation
The new page follows the same structure as other configuration docs — features list, install code groups for all four package managers, and two usage examples (auto-detect config file vs. inline config). The Get Started page and
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3684 +/- ##
=======================================
Coverage 39.39% 39.39%
=======================================
Files 520 520
Lines 19279 19279
Branches 5708 5708
=======================================
Hits 7595 7595
Misses 9445 9445
Partials 2239 2239
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Docs look good overall — clean Vite plugin page and consistent npm install → npm add sweep. Two small heading/link nits below.
|
|
||
| # Vite | ||
|
|
||
| ### About |
There was a problem hiding this comment.
### About (h3) directly under # Vite (h1) skips h2 and is inconsistent with the sibling config pages (input.md, output.md, parser.md), which all jump straight into ## sections after the h1. Consider either promoting this to ## About or dropping the heading and folding the two sentences into the intro paragraph under # Vite.
| ### About | |
| ## About |
| ## Features | ||
|
|
||
| - runs automatically as part of your Vite build | ||
| - reads your existing [configuration](/openapi-ts/get-started) (or accepts inline config) |
There was a problem hiding this comment.
This links to /openapi-ts/get-started, but that page covers installation & quickstart, not the configuration file format. Line 61 of this same file already links correctly to /openapi-ts/configuration. Should this point there too?
| - reads your existing [configuration](/openapi-ts/get-started) (or accepts inline config) | |
| - reads your existing [configuration](/openapi-ts/configuration) (or accepts inline config) |
@hey-api/codegen-core
@hey-api/json-schema-ref-parser
@hey-api/nuxt
@hey-api/openapi-ts
@hey-api/shared
@hey-api/spec-types
@hey-api/types
@hey-api/vite-plugin
commit: |

Closes #1878