[#3] Lot Merge: extract mergeOpenLots pure module + tests + modal rewire#11
Merged
Conversation
… add tests\n\nDecisions:\n- Implemented mergeOpenLots(trades, asset) as a pure helper. It prefers lotEngine, falls back to compute, and finally uses a safe heuristic for HOLDING/ASSIGNED-only cases so Node tests can run.\n- Modal preview now derives merged preview via mergeOpenLots against a cloned trades array; confirmMerge persists merged trades via existing save()/render().\n- Added Node test covering merging two HOLDING lots and ensuring non-target assets remain untouched.\n\nFiles changed:\n- src/js/05a-merge-open-lots.js (new)\n- src/js/14-merge-modal.js (modified)\n- test/merge.test.js (new)\n\nNotes:\n- Module uses a temporary global-swap only when falling back to compute; this keeps behaviour identical in browser concatenation while remaining testable in Node.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Extract mergeOpenLots into pure module; rewire merge modal to use it; add tests\n\nDecisions:\n- Implemented mergeOpenLots(trades, asset) as a pure helper. It prefers lotEngine, falls back to compute, and finally uses a safe heuristic for HOLDING/ASSIGNED-only cases so Node tests can run.\n- Modal preview now derives merged preview via mergeOpenLots against a cloned trades array; confirmMerge persists merged trades via existing save()/render().\n- Added Node test covering merging two HOLDING lots and ensuring non-target assets remain untouched.\n\nFiles changed:\n- src/js/05a-merge-open-lots.js (new)\n- src/js/14-merge-modal.js (modified)\n- test/merge.test.js (new)\n\nNotes:\n- Module uses a temporary global-swap only when falling back to compute; this keeps behaviour identical in browser concatenation while remaining testable in Node.\n\nCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com
Implemented by GitHub Copilot CLI.