Tooltips: extend ⓘ + popover to remaining PnL tiles and Net Cost hero#27
Merged
Conversation
Batch B — adds tooltips to Total Premium Collected, Total Notional, Portfolio APR, and Return Rate so the Premium P&L Total tab is internally consistent (every tile gets the same affordance). Batch A — Holdings card Net Cost hero gets a tooltip explaining the premium-reduced entry-price lens and how it differs from the new Unrealised P&L mark-to-market lens (PRD #12 user story 13). CSS generalised: tooltip popover moves from .ppnl-card.has-tip to a reusable .has-tip class so future opt-in elsewhere is one line. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- .hcard had overflow:hidden, which clipped the Net Cost popover anchored to the .hcard-hero inside. Removed; added a regression test that reads the stylesheet and asserts .hcard never sets it again. - Dropped the native title= attribute we were emitting alongside data-tip on each PnL tile. Browsers were rendering the slow native tooltip on top of the styled popover. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #26 to extend the new ⓘ + styled-popover affordance.
.ppnl-card.has-tipto a reusable.has-tipclass so future opt-in elsewhere is one line.Test plan
npm test— 52 tests pass (5 new integration tests)python3 build.py --check— JS syntax OK🤖 Generated with Claude Code