PnL Slice 3: Monthly tab Realised rename + computePnl-sourced values#28
Merged
Conversation
Extend computePnl to expose realisedByMonth bucketed by settled-event expiry (asset-filter aware). Switch the Premium P&L Monthly tab off the legacy netPnl formula (totalPrem − assignmentLoss + callAwayCredit) to the cash-flow lens, and rename the column header Net P&L → Realised P&L. Net Cost tooltip portion of issue #15 already shipped in d76a1dc / 24dc433. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15.
Summary
computePnlexposesrealisedByMonth: { 'YYYY-MM': delta }, bucketed by settled-event expiry, asset-filter aware.realisedByMonthinstead of the legacynetPnl = totalPrem − assignmentLoss + callAwayCreditformula.Test plan
npm test— 58 passing (3 new unit + 2 new integration tests for slice 3)python3 build.py --check— clean🤖 Generated with Claude Code