Hero: add Total P&L tile beside Realised line#39
Merged
Conversation
Sources unrealised, total, missingSpotAssets from computePnl — no engine changes. Handles three states: no open lots, all-spot-missing (dashes + sub-line), partial/ok (values + optional sub-line). No asterisks. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36. Implements ADR 0004.
Summary
#cpnl-tilein.cpnl-hero-hdshowing stackedUnrealised(small) andTotal(peer weight to Realised number), plus muted sub-line for missing-spot.rHeroTile()in07-render-charts.js— sourcesunrealised,total,missingSpotAssetsfromcomputePnland open-lot inventory fromcompute().lots. Called at top ofrCpnlChart(), so asset filter + render cycle drive it for free..cpnl-hero-tileblock — vars only, no hardcoded colours.States
—, Total = Realised, no sub-line.—, sub-linespot unavailable: <ASSETS>. Realised line unaffected.Test plan
python3 build.py --checkpassesnpm testpasses (64 tests, +5 new)