feat: add jira service and e2e node#293
Conversation
|
Thanks for the very thorough PR again ⭐️ The structure is clean and closely follows the existing GitHub/Linear/Sentry nodes: modular handler plus registry, dedicated properties component, credential type with an additive migration, docs, and tests 🙏 One functional issue should be fixed before merge, and one compatibility claim should be clarified. Fixes1. The handler reads 2. The advertised v2 / Data Center support does not match body serialization.
But Jira Server/Data Center v2 examples use plain strings for issue
The default v3 path is fine, but the credential dialog and docs suggest Nits
Nice work overall 🔥 🚀 Thank you once again |
Thanks for your review, I've updated. |
|
Thanks @eryue0220 🙏 , the previous fixes look good and CI is green. One product requirement is important for us before merge: this node should support self-hosted Jira / Data Center, not only Jira Cloud. Right now Required before merge:
I think Please add v2/Data Center path tests for search, changelog, assignee/user identity, and create user. The text body handling added in the last commit is good and should stay. |
|
We’ll need to update 94 for our Alembic credential for the team file sharing feature , which will be merged into main with 0.0.61. Just wanted to give you a quick heads-up. Great work, thank you so much. 🙏 |
Got it, thanks for your sharing. |
I’ve update for this. |
|
Thanks for the Data Center work @eryue0220 🙏 , this is a big step up. Search, changelog, text bodies, and the accountId vs username handling all look right now, and the deployment flag is a clean way to model it. There is still one thing that breaks on real self-hosted before we can call Data Center supported.
Could you branch One smaller thing, not strictly blocking: auth is still Cloud shaped. The service always sends Basic auth with email and api_token. Username/password Basic auth can work on Data Center, so this will not always fail, but the Email and API Token labels are confusing for a self-hosted setup, and Data Center personal access tokens use Bearer auth, which we do not support yet. A follow-up auth mode for Data Center, such as basic vs PAT, would make this cleaner. At minimum, the Data Center credential labels/docs should make the supported auth path clear. Everything else looks good and CI is green. Once |
Sorry for the missing, I've updated. |
|
Thanks 👑 , we’re happy to have such a fabulous contribution. 🚀 |
This pr is to add Jira e2e node and service