Skip to content

Make searchable dropdown selections stable#303

Merged
mbakgun merged 4 commits into
mainfrom
searchable-dropdowns
Jul 9, 2026
Merged

Make searchable dropdown selections stable#303
mbakgun merged 4 commits into
mainfrom
searchable-dropdowns

Conversation

@mbakgun

@mbakgun mbakgun commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaced the new credential type picker with the shared searchable dropdown.
  • Switched AI Agent, LLM, fallback model, and dashboard chat model pickers to searchable dropdowns.
  • Fixed the searchable dropdown so clicking the already-selected option keeps the selection instead of clearing the displayed value.
  • Updated credential E2E coverage for the searchable type picker and added a regression test for reselecting the current type.

Impact

Users can search long credential/model lists consistently, and the new credential dialog no longer loses the selected type when the current option is clicked again.

Validation

  • bun run lint (passes; existing CodexFollowupView.vue vue/no-v-html warnings remain)
  • bun run typecheck
  • ./run_e2e.sh e2e/tab-credentials.spec.ts (9 passed)
  • git diff --check
  • SECRET_KEY=test-secret-key-for-tests-only-32-bytes ./check.sh ran; frontend/backend lint passed, but the full parallel backend suite reported timeout/flaky failures in test_chart_output_node.py and test_mcp_jsonrpc_tool_calls.py.
  • SECRET_KEY=test-secret-key-for-tests-only-32-bytes uv run pytest tests/test_chart_output_node.py tests/test_mcp_jsonrpc_tool_calls.py -v (7 passed on rerun).

@ckakgun ckakgun marked this pull request as ready for review July 9, 2026 12:35
mbakgun added 3 commits July 9, 2026 18:06
This update introduces searchable dropdown selectors for selecting credentials and models in the Docs chat dialog, enhancing user experience. The previous select elements have been replaced with `SearchableSelect` components, allowing for easier navigation and selection. Additionally, the related state management and placeholder texts have been updated accordingly.
@mbakgun mbakgun enabled auto-merge (squash) July 9, 2026 16:12
@mbakgun mbakgun merged commit 2cbbfc6 into main Jul 9, 2026
2 checks passed
@mbakgun mbakgun deleted the searchable-dropdowns branch July 9, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants