refactor(core): dedupe stoplist and normalize generics to typing.*#247
Merged
Conversation
Lift the duplicated _STOPWORDS frozenset out of freshness, goal_drift, and retrieval_lineage into a shared evalview.core.text module. Convert PEP 585 builtins (set[...], frozenset[...]) to typing.Set / FrozenSet across the six new modules to match CLAUDE.md's Python-3.9 style. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_STOPWORDSfrozenset out offreshness.py,goal_drift.py, andretrieval_lineage.pyinto a newevalview/core/text.py(drops ~36 duplicated lines).set[...],frozenset[...]) totyping.Set/FrozenSetacrosschaos.py,fleet.py,freshness.py,goal_drift.py,retrieval_lineage.pyto match the Python-3.9 style mandated inCLAUDE.md.Pure cleanup — no behavior change. Both nits were flagged by the post-merge audit of #233 / #245.
Test plan
mypyclean on all six touched filespytest -k "freshness or goal_drift or retrieval_lineage or chaos or fleet"— 103/103 pass in 2.56s🤖 Generated with Claude Code