fix: bypass urwid UI when stdout is not a TTY#8
Open
mktwix wants to merge 1 commit into
Open
Conversation
Without a terminal, cli_progress wraps install/apply in an urwid MainLoop that never exits after the subprocess finishes. This leaves apply_configs and apply_users stuck indefinitely and prevents sing-box configs from reloading. Run the wrapped command directly in non-interactive environments. Fixes hiddify/Hiddify-Manager#5479 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
cli_progresswrapsinstall.sh apply_configs/apply_userswithout a real TTY (non-interactive SSH, cron, background panel jobs), the urwidMainLoopnever exits after the subprocess finishes. The process spins indefinitely and blocks subsequent applies.This leaves sing-box configs stale after Admin API user create/renew even though the panel DB was updated.
Fix
If
stdoutis not a TTY, run the wrapped command directly viasubprocess.call()and skip the urwid UI.Interactive terminal runs still show the progress UI.
Reproduction
Related
Verified on production Hiddify Manager 12.3.3 (3 nodes).
Made with Cursor