Use QScreen for Desktop::{size,workspace}#217
Merged
Screwtapello merged 1 commit intoSep 1, 2025
Conversation
Qt 5.0 adds the QScreen API, which exposes enough information that
Desktop::{size,workspace} no longer needs to fall back to Win32/Xlib. I
manually tested that this seems to give the same exact answers as the
Xlib path (though it technically goes a different route for
Desktop::size.)
This was referenced Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qt 5.0 adds the QScreen API, which exposes enough information that
Desktop::{size,workspace}no longer needs to fall back to Win32/Xlib. I manually tested that this seems to give the same exact answers as the Xlib path (though it technically goes a different route forDesktop::size.)Since this API doesn't exist until Qt 5.0, this breaks the Qt 4 build. However, Qt 4 is long dead now. Even if we wanted to test it and keep it working, it would be hard since no recent distro releases ship Qt 4. Instead of bifurcating this any further, I think the right thing to do is just drop Qt 4 support and remove all of the legacy Qt 4 paths for once and for all: #216
Mirrored in:
Desktop::{size,workspace}ares-emulator/ares#2189Desktop::{size,workspace}bsnes-emu/bsnes#362