fix(settings): consolidate borderlessWindows and fix settings persistence#12
Merged
fix(settings): consolidate borderlessWindows and fix settings persistence#12
Conversation
hikaps
force-pushed
the
fix/settings-save
branch
from
cf2e346 to
d0a0a13
Compare
Remove per-instance borderless from InstanceConfig and profile persistence. Inject SettingsManager into SessionRunner to read borderlessWindows at session start instead of maintaining a duplicate property. Remove leftover steamIntegration from SettingsManager (already handled per-preset by PresetManager).
Pass borderless setting through WindowManager to KWin script instead of hardcoding noBorder=true. The KWin script now conditionally removes window decorations based on the global borderlessWindows setting from SettingsManager.
Remove dead per-instance borderless checkbox from SessionSetupPage (read-only, no onToggled handler). Fix SettingsPage borderless checkbox to read/write only from settingsManager. Remove leftover steamIntegration checkbox from SettingsPage.
hikaps
force-pushed
the
fix/settings-save
branch
from
d0a0a13 to
8d75993
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
borderlessWindowsas a global-only setting inSettingsManager, removing the duplicate per-instanceborderlessfromInstanceConfigand profile persistenceborderlessWindowssetting to the KWin window positioning script (was hardcodednoBorder = trueregardless of the setting)steamIntegrationproperty fromSettingsManager(already handled per-preset byPresetManager)SessionSetupPage(read-only, noonToggledhandler)SettingsPage(binding would break after first toggle)SettingsManagersave only the changed setting instead of rewriting all settings on every changeTest Plan
testVersionfailure unrelated)-bflag is passed when enabled~/.config/couchplayrc)