feat(presets): generalize Flatpak/native detection for builtin launch presets#13
Merged
feat(presets): generalize Flatpak/native detection for builtin launch presets#13
Conversation
6703b6a to
5564c47
Compare
5564c47 to
461b04b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveLaunchCommand()helper inPresetManagerflatpakAppIdandflatpakArgsfields to theLaunchPresetstruct so each preset declares its Flatpak alternative, with full serialization and QML exposure~/.config/couchplayrcwith a 24h TTL to avoid repeatedwhich/flatpaksubprocess calls at startupContext
Previously only Heroic had Flatpak awareness for its launch command. Steam and Lutris presets hardcoded native commands (
steam -tenfoot -steamdeck,lutris), which would fail on systems where only the Flatpak version is installed (common on Bazzite/immutable distros).Changes
steam -tenfoot -steamdeckflatpak run com.valvesoftware.Steam -tenfoot -steamdeckheroicflatpak run com.heroicgameslauncher.hgllutrisflatpak run net.lutris.LutrisResolution priority: native first → Flatpak fallback → native as-is (graceful degradation).
Untouched
HeroicConfigManagerconfig path detection andisFlatpak()display flagSteamConfigManagerconfig sync pathsCommandVerifierimplementation