fix(audio): clear runtime access tracking on TCP listener teardown#14
Merged
fix(audio): clear runtime access tracking on TCP listener teardown#14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
m_runtimeAccessSetForUidincleanupTcpListenerIfLast()when the TCP listener config is removed, soSetupRuntimeAccess()re-runs on the next session start and recreates the PipeWire PulseAudio TCP listenerProblem
Audio routing broke after closing instances and starting a new session. The TCP listener config (
50-couchplay.conf) was removed during teardown, butm_runtimeAccessSetForUidstill contained the compositor UID. On the next launch,LaunchInstance()saw the UID in the set and skippedSetupRuntimeAccess()entirely — so the TCP listener was never recreated. Instances launched withPULSE_SERVER=tcp:127.0.0.1:4713but nothing was listening.Workaround was reinstalling the helper, which restarts the daemon and clears the in-memory set.
Testing
couchplayandcouchplay-helpersuccessfullyhelper/CouchPlayHelper.cpp