chore(codeowners): own main with all three core maintainers - #160
Merged
Conversation
Only @hikariming was a code owner, so with "Require review from Code Owners" on main every PR — including ones from the other two maintainers reviewing each other — stalled waiting on a single person. List all three maintainers instead. GitHub never counts a PR author's own approval, so the one required approval always has to come from one of the other two, which is the cross-review we actually want. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.github/CODEOWNERSlisted only@hikarimingas the owner of*. Combined with theProtect mainruleset's Require review from Code Owners, that meant every PR — including ones the other two maintainers opened and could have reviewed for each other — was blocked until one specific person approved.This lists all three core maintainers as owners of the repository.
Why this gives us cross-review
GitHub never counts a pull request author's own approval, and a code owner cannot satisfy the code-owner requirement on their own PR. So with
* @hikariming @KurosawaGeeker @AsperforMiasandrequired_approving_review_count: 1, whoever opens a PR must get an approval from one of the other two before it can land.Paired with a ruleset change (applied separately): admin bypass tightened from
alwaystopull_request, andrequire_last_push_approvalturned on.🤖 Generated with Claude Code