feat(config): wire GoPro token through Q2GoogleSettings#12
Merged
Conversation
Add gopro_access_token with GP_ACCESS_TOKEN and Q2GOOGLE_GOPRO_ACCESS_TOKEN aliases, pass it to AsyncGoProClient, bump gopro-api to 0.0.9, and add a uv path source for sibling-repo development. Co-authored-by: Cursor <cursoragent@cursor.com>
The action expects type_labels.breaking, not breaking_change. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gopro_access_tokentoQ2GoogleSettingswithGP_ACCESS_TOKENandQ2GOOGLE_GOPRO_ACCESS_TOKENaliases.access_token=cfg.gopro_access_tokenintoAsyncGoProClientso q2google owns orchestration config.gopro-api~=0.0.9and add[tool.uv.sources]path override for sibling-repo dev.Depends on gopro-api 0.0.9 (lazy settings +
extra="ignore"). Merge and publish gopro-api first.Test plan
uv syncwith sibling../gopro-apicheckoutuv run q2google sync ...withGP_ACCESS_TOKENin.envQ2GOOGLE_GOPRO_ACCESS_TOKENset (unsetGP_ACCESS_TOKEN)uv run pytest testsMade with Cursor