Skip to content

Fix some bugs:#1

Open
zh-impact wants to merge 3 commits into
hingsir:masterfrom
zh-impact:master
Open

Fix some bugs:#1
zh-impact wants to merge 3 commits into
hingsir:masterfrom
zh-impact:master

Conversation

@zh-impact

Copy link
Copy Markdown

Fix for that issues:
If the filename like below:
custom-a-b.css
main-test.js
the replace will apply in props

the manifest.json will be:
{
"custom-a.css?v=b": "custom-a-b.css?v=xxxxx",
"main.js?v=test": "main-test.js?v=xxxxx"
}

So, I parse the string to Object, then travel it, only replace the
value in object.

x4storm added 2 commits July 21, 2017 01:52
Fix for that issues:
If the filename like below:
custom-a-b.css
main-test.js
the replace will apply in props

the  manifest.json will be:
{
  "custom-a.css?v=b": "custom-a-b.css?v=xxxxx",
  "main.js?v=test": "main-test.js?v=xxxxx"
}

So, I parse the string to Object, then travel it, only replace the
value in object.
Fix for this issues:
filename:
jquery.1.7.0.js
test.min.js

for multi dots in finename
@zh-impact

Copy link
Copy Markdown
Author

Fix for this issues:
filename:
jquery.1.7.0.js
test.min.js

for multi dots in finename

Fix for this filename:
angular-datatables.light-columnfilter.a.js

beacause the gulp-rev always prepend hash in first dots.
so reg should consider after .-
@zh-impact

Copy link
Copy Markdown
Author

Fix for this issues:
filename:
jquery.1.7.0.js
test.min.js

for multi dots in finename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant