Extract shared definitions for typed and untyped representations#57
Merged
Conversation
VietAnh1010
requested changes
Aug 29, 2025
VietAnh1010
left a comment
VietAnh1010
left a comment
Collaborator
There was a problem hiding this comment.
Very nice improvement, if we can merge this.
| exception Foo of string | ||
|
|
||
| let rec get_tactic e = | ||
| let open Hipcore_common.Tactics in |
Collaborator
There was a problem hiding this comment.
I am not sure whether this tactic is still relevant. But we can keep it there.
| @@ -1,96 +1,3 @@ | |||
| let ( let@ ) f x = f x | |||
Collaborator
There was a problem hiding this comment.
Should this be put into utils?
| let ( let@ ) f x = f x | ||
|
|
||
| (** A write-only list that supports efficient accumulation from the back *) | ||
| module Acc : sig |
Collaborator
There was a problem hiding this comment.
This, should be move into utils.
Collaborator
|
Is this ready to be merged? Let's push, as Better to merge this early, and then we resolve the conflicts early. |
Collaborator
Author
|
Sure, feel free to merge. |
VietAnh1010
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges some of the definitions which the recursive AST types do not depend on (e.g.
lemma,pred_def) by functorizing them, and moves some shared libraries (e.g.Types,Common) to their own library. The new structure aims to preserve the interface currently exposed byHiptypesandTypedhip.