Revive OCaml frontend#65
Merged
Merged
Conversation
VietAnh1010
requested changes
Mar 9, 2026
VietAnh1010
left a comment
VietAnh1010
left a comment
Collaborator
There was a problem hiding this comment.
Just need to decouple a bit, and then we are good.
| (public_name heifer.prover) | ||
| (inline_tests) | ||
| (libraries core parsing util why3_prover printbox-text) | ||
| (libraries core parsing util why3_prover printbox-text ocamlfrontend) |
Collaborator
There was a problem hiding this comment.
Can we remove this dependency on ocamlfrontend somehow?
| set_goal (Pctx.create goal); | ||
| print_proof_state () | ||
|
|
||
| let read_file filename = |
Collaborator
There was a problem hiding this comment.
To remove the dependency on ocamlfrontend, we shall move this to somewhere else, preferably outside of prover. We will import this at the top-level executable Heifer.
Collaborator
Author
|
Did as you suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to review: look at all the mli files and tests first to see what is added, then look at the implementations.
Next steps: