Add CMake setup#329
Draft
r-ash wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is really quite a mess and I'm a bit skeptical of the value added at this point. This was built with https://github.com/friendlyanon/cmake-init
clang-tidy is causing a lot of pain and not really that much tidying up we need to do. To get this ready still remaining TODO is
generated_new_targetI'm wondering if this just doing too much really for a first pass. Perhaps we should try add a very simple CMake setup which compiled the header only code, and runs the standalone .cpp file with ctest and leave it at that for now? We can add clang-tidy later