Skip to content

feat: guide setup through output selection - #12

Merged
hhhjin merged 3 commits into
mainfrom
codex/output-setup-empty-dir
Mar 18, 2026
Merged

hhhjin merged 3 commits into
mainfrom
codex/output-setup-empty-dir

Conversation

@hhhjin

@hhhjin hhhjin commented Mar 18, 2026

Copy link
Copy Markdown
Member

Summary

  • require users to choose an output directory before exposing the rest of the TUI setup flow
  • move preset output paths into dedicated syncdown subdirectories and require managed output directories to be empty
  • reuse the same output directory validation in both TUI and CLI config flows and add coverage for the new behavior

Testing

  • bun run lint:fix
  • bun test apps/cli/src/program.test.ts packages/core/src/config.test.ts packages/tui/src/*.test.ts

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines the initial setup experience by introducing a guided output directory selection process. It ensures that users configure a valid and empty output location early in the TUI flow, preventing potential data conflicts. Furthermore, it standardizes preset output paths to dedicated "syncdown" subdirectories and integrates robust directory validation across both command-line and terminal user interface configurations, enhancing overall system stability and user clarity.

Highlights

  • User Guidance: The TUI setup now prioritizes output directory selection, guiding users to choose a valid, empty directory before proceeding with other configurations.
  • Standardized Output Paths: Preset output paths (Desktop, Documents, Downloads, Home) now default to dedicated "syncdown" subdirectories, ensuring better organization and preventing conflicts.
  • Enhanced Validation: A unified validation logic for managed output directories has been implemented and applied across both the TUI and CLI configuration flows, requiring chosen directories to be empty.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively implements a guided setup flow by requiring users to select an output directory before proceeding. The new validation ensuring the output directory is empty is a crucial improvement and has been consistently applied to both the CLI and TUI. The related refactoring to centralize this validation logic is well done. The changes are also well-supported by new tests. I have one suggestion to improve code maintainability in the test suite by removing a duplicated helper function.

Comment thread packages/tui/src/app.test.ts Outdated
@hhhjin
hhhjin merged commit 02566e2 into main Mar 18, 2026
1 check passed
@hhhjin
hhhjin deleted the codex/output-setup-empty-dir branch March 18, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant