Skip to content

fix: support more awk variants in install script - #8

Merged
hhhjin merged 1 commit into
mainfrom
codex/fix-install-script-awk
Mar 18, 2026
Merged

hhhjin merged 1 commit into
mainfrom
codex/fix-install-script-awk

Conversation

@hhhjin

@hhhjin hhhjin commented Mar 18, 2026

Copy link
Copy Markdown
Member

Summary

  • rewrite the release tag selection awk condition to avoid syntax errors on some awk implementations
  • keep the installer behavior the same while restoring curl ... | sh installs
  • add a patch changeset describing the install-script fix

Testing

  • bun run lint:fix

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical compatibility issue within the installation script, specifically targeting the awk command used for resolving release tags. By refactoring the awk condition, the script now supports a wider range of awk implementations, ensuring that curl | sh installations function correctly across different environments without altering the core installation logic.

Highlights

  • Awk Compatibility: Rewrote the release tag selection awk condition to prevent syntax errors on various awk implementations.
  • Installer Behavior: Maintained the existing installer behavior while re-enabling curl ... | sh installations.
  • Changelog: Added a new changeset entry detailing the install script fix.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@hhhjin
hhhjin merged commit 4ce279a into main Mar 18, 2026
1 check passed
@hhhjin
hhhjin deleted the codex/fix-install-script-awk branch March 18, 2026 05:02

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request includes a changeset file indicating a patch for @syncdown/cli to fix an issue where the install script failed on certain awk implementations when resolving the latest CLI release tag. The corresponding code change in scripts/install.sh involves reformatting a multi-line if condition within an awk script, adjusting line breaks and parentheses without altering the logical expression itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant