Skip to content

Block sync for incompatible vault paths - #45

Merged
hhhjin merged 5 commits into
hjinco:mainfrom
algiadev8:feat/block-incompatible-path
Sep 18, 2026
Merged

hhhjin merged 5 commits into
hjinco:mainfrom
algiadev8:feat/block-incompatible-path

Conversation

@algiadev8

@algiadev8 algiadev8 commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem

macOS allows users to create file and folder paths that cannot be applied on Windows.

Previously, these paths could be added to sync, causing errors when a Windows client attempted to apply them.

Summary

  • Prevented paths incompatible with supported platforms from being synced
  • Blocked incompatible local paths before upload
  • Prevented incompatible remote paths from being applied to the local vault
  • Made blocked files visible in the File Explorer and sync settings
  • Updated the existing File Explorer and sync setting tooltip to show guidance specific to incompatible paths

Details

  • Added portable path validation for Windows-incompatible characters, reserved device names, trailing spaces and dots, and other invalid path components
  • Added incompatible_path as a blocked reason
  • Renamed the blocked-file API to listBlockedSyncFiles()
  • Retained the previous listFileSizeBlockedFiles() API and related types as deprecated aliases for backward compatibility
  • Updated File Explorer warning tooltips to explain incompatible paths
  • Updated sync settings to report file-size and incompatible-path blocks separately
  • Added the new UI messages to all supported locales
  • Preserved path whitespace in encrypted metadata so trailing spaces can be detected instead of silently changing the path

Validation

  • Verified with a real vault that paths containing characters such as || are blocked and not synced

@hhhjin

hhhjin commented Sep 15, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00d3965266

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/sync-client/src/sync/core/vault-path-policy.ts Outdated
Comment thread packages/sync-client/src/sync/engine/push-service.ts
@hhhjin

hhhjin commented Sep 18, 2026

Copy link
Copy Markdown
Member

great work, thanks for the pr!

@hhhjin
hhhjin merged commit ea9eba4 into hjinco:main Sep 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants