Skip to content

Add Sync Plus organization vault sharing - #46

Merged
hhhjin merged 1 commit into
mainfrom
codex/plus-vault-sharing
Sep 28, 2026
Merged

hhhjin merged 1 commit into
mainfrom
codex/plus-vault-sharing

Conversation

@hhhjin

@hhhjin hhhjin commented Sep 28, 2026

Copy link
Copy Markdown
Member

Adds encrypted organization vault sharing to Sync Plus and self-hosted servers. Owners and administrators manage invitations and vault access; recipients receive keys through verified administrator approval and set their own vault passwords.

Changes

  • Add organization management pages, scoped vault grants, key enrollment/recovery, and durable sync-access revocation with scheduled retries.
  • Add Sync Plus billing and organization-scoped checkout, subscription changes, and billing status. Pause shared sync when Plus expires while preserving remote data.
  • Update Obsidian vault setup and sharing controls, require empty local vaults for invited vaults, and preserve connections to older self-hosted servers.
  • Include D1 and coordinator SQLite migrations, localized UI text, and concise plugin release notes. Managed deployment requires the Plus monthly and annual Polar product IDs.

Validation

  • 562 tests passed: API unit (427), targeted Cloudflare integration (25), Node end-to-end (8), plugin connection/subscription tests (50), sync-client sharing/vault tests (21), vault crypto (13), and website billing (18).
  • Workspace typecheck, Obsidian plugin build, website build, public-asset consistency, API lockfile consistency, and diff whitespace checks passed.
  • Attempted the Cloudflare quick before/after benchmark against origin/main. The harness rejected the comparison before measurements with Incompatible comparison: environment because this change modifies the fingerprinted wrangler.jsonc. No performance comparison is available.

@hhhjin

hhhjin commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T02:18:55.809218Z e61e10d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e61e10d7d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/api/src/sharing/application/service.ts
@hhhjin
hhhjin merged commit 4e439bd into main Sep 28, 2026
4 checks passed
@hhhjin
hhhjin deleted the codex/plus-vault-sharing branch September 28, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant