Repository navigation
fix(cli): stop watch after terminal sync failures - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
synch watchhit a terminal sync condition, the sync loop could stop while the CLI kept running and waiting for a signal. That left users with a live watch process but no further sync activity; remote vault and storage quota stops also had no CLI explanation.This change makes the sync engine report terminal stop reasons to the CLI.
synch watchnow prints the reason and exits with status 1 for remote vault unavailability, sync history mismatch, or remote storage quota exhaustion. Transient connection failures continue to retry with backoff. SIGINT/SIGTERM handling starts after initial connection and sync, so a stalled startup does not swallow Node's default signal termination.Validation
pnpm -C apps/cli typecheckgit diff --check