Update master with ballot 1.0.0 version#105
Merged
Merged
Conversation
- Updated to XtEHR logical models version 0.3.0 - Added all 43 StructureDefinition JSON files - Updated parseLogicalModels.js to read from XtEHR-models/ - Created migrateMappingTsv.js to preserve FHIR mappings during migration - Migration handles one-to-many mappings correctly (1511 total rows) - Created compareModels.js for version comparison - Updated download script to v0.3.0 - Generated new xtehr-model.csv with 1169 elements
Ballot fixes
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Imaging IG sources and generated outputs for the 1.0.0 ballot release, including multi-version (R4/R5) preprocessing, refreshed examples/profiles, and publication metadata.
Changes:
- Updates IG publication metadata/ini files and adds redirect/requirements artifacts for the ballot release.
- Refactors multiple version-specific liquid sources into plain
.fsh/.mdoutputs and adds new examples (semi-structured bundle/docref + validator workaround observation). - Expands Bundle profile slicing/entries and adds obligation profiles for producer requirements mapping.
Reviewed changes
Copilot reviewed 241 out of 350 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| ig.ini | Points root IG build to redirect IG JSON |
| Requirements-fromNarrative.json | Adds computable “Requirements” resource for narrative-derived conformance |
| README.md | Adds repository and build links + multi-version notes |
| .github/workflows/deploy-to-repos.yml | Avoids auto-deploy workflow on 1.0.0-ballot branch |
| _preprocessMultiVersion.sh | Adds optional CLI arg to build one or both FHIR versions |
| _preProcessAndCheckAll.sh | Adds publisher bootstrapping + conditional R4/R5 build steps |
| ig-src/publication-request.json | Updates publication request to hl7.fhir.eu.imaging 1.0.0-ballot |
| igs/imaging-r4/publication-request.json | Same publication-request update for R4 output |
| ig-src/ig.liquid.ini | Splits IG output selection for R4 vs R5 builds |
| igs/imaging-r4/ig.ini | Updates R4 IG file name to non-suffixed package id |
| igs/imaging-r5/ig.ini | Adds R5 IG ini with explicit IG JSON |
| igs/imaging-r5/ig.liquid.ini | Removes liquid ini in favor of concrete ini |
| ig-src/input/includes/variable-definitions.md | Adds version flags + new variable links (currently has issues) |
| igs/imaging-r4/input/includes/variable-definitions.md | Same as above for generated R4 |
| ig-src/input/pagecontent/current-status.md | Updates narrative about ballot processing/testing |
| igs/imaging-r4/input/pagecontent/current-status.md | Same updates in generated R4 content |
| ig-src/input/pagecontent/index.md | Updates landing page ballot callout/scope text |
| igs/imaging-r4/input/pagecontent/index.md | Same landing changes in generated R4 |
| ig-src/input/pagecontent/imaging-report.md | Adds “Report Versions” guidance |
| igs/imaging-r4/input/pagecontent/imaging-report.md | Same “Report Versions” content in R4 |
| ig-src/input/pagecontent/examples.md | Removes HL7v2 TBD entry and renumbers examples |
| igs/imaging-r4/input/pagecontent/examples.md | Same examples list change for R4 |
| ig-src/input/pagecontent/use-case-other-specs.md | Fixes heading typo “relaed” → “related” |
| igs/imaging-r4/input/pagecontent/use-case-other-specs.md | Same typo fix in generated R4 |
| ig-src/input/pagecontent/changes.md | Adds 1.0.0-ballot change log section |
| igs/imaging-r4/input/pagecontent/changes.md | Same change log content for R4 output |
| ig-src/input/pagecontent/artifacts-structural.md | Adjusts headings and SQL filters to exclude obligation artifacts |
| igs/imaging-r4/input/pagecontent/artifacts-structural.md | Same structural artifacts page changes |
| ig-src/input/pagecontent/artifacts-obligations.md | Adds obligations artifacts listing page |
| igs/imaging-r4/input/pagecontent/artifacts-obligations.md | Same obligations page in generated R4 |
| ig-src/input/pagecontent/design-considerations-document-bundle-rules.liquid.md | Splits R4/R5 narrative with liquid conditionals |
| igs/imaging-r4/input/pagecontent/design-considerations-document-bundle-rules.md | Mirrors adjusted document bundle rules content |
| ig-src/input/pagecontent/design-consideration-linking-to-bodysites.liquid.md | Adds R4/R5 conditional text, escapes liquid refs |
| igs/imaging-r4/input/pagecontent/design-consideration-linking-to-bodysites.md | Mirrors updated R4 body-site narrative |
| ig-src/input/pagecontent/design-consideration-data-entrypoints.liquid.md | Reintroduces page with version-conditional diagrams |
| igs/imaging-r4/input/pagecontent/design-consideration-data-entrypoints.md | Updates diagram references for R4 |
| ig-src/input/pagecontent/design-consideration-composition-diagnosticreport.liquid.md | Version-conditional narrative and diagrams |
| igs/imaging-r4/input/pagecontent/design-consideration-composition-diagnosticreport.md | Mirrors updated R4 composition/dr linkage narrative |
| ig-src/input/pagecontent/design-consideration-procedure-adverse-reaction.liquid.md | Version-conditional mermaid diagrams |
| igs/imaging-r4/input/pagecontent/design-consideration-procedure-adverse-reaction.md | Updates R4 adverse reaction diagram text |
| ig-src/input/pagecontent/design-consideration-actors-obligations.md | Minor formatting tweaks |
| igs/imaging-r4/input/pagecontent/design-consideration-actors-obligations.md | Same formatting tweaks for R4 |
| ig-src/input/pagecontent/dependencies.liquid.md | Adds dependency/globals tables for R5, TODO for R4 |
| igs/imaging-r4/input/pagecontent/dependencies.md | Adds spacing/structure for dependencies page |
| ig-src/input/pagecontent/contributors.md | Updates contributors table formatting/content |
| igs/imaging-r4/input/pagecontent/contributors.md | Same contributors change in R4 output |
| igs/imaging-r4/input/ignoreWarnings.txt | Adds additional ignored validator warnings |
| ig-src/input/fsh/terminologies/section-terminology.fsh | Adds LOINC copyright insertion |
| ig-src/input/fsh/terminologies/category-and-type.fsh | Adds LOINC copyright insertion |
| igs/imaging-r4/input/fsh/terminologies/section-terminology.fsh | Same LOINC copyright insertion for R4 |
| igs/imaging-r5/input/fsh/terminologies/section-terminology.fsh | Same LOINC copyright insertion for R5 |
| igs/imaging-r4/input/fsh/terminologies/category-and-type.fsh | Same LOINC copyright insertion for R4 |
| igs/imaging-r5/input/fsh/terminologies/category-and-type.fsh | Same LOINC copyright insertion for R5 |
| ig-src/input/fsh/profiles/im-report.fsh | Updates bundle entry slicing/allowed slices |
| igs/imaging-r4/input/fsh/profiles/im-report.fsh | Same bundle slicing changes for R4 |
| igs/imaging-r5/input/fsh/profiles/im-report.fsh | Same bundle slicing changes for R5 |
| ig-src/input/fsh/profiles/im-imagingstudy.liquid.fsh | Updates identifier/basedOn slicing (generated) |
| igs/imaging-r4/input/fsh/profiles/im-imagingstudy.fsh | Mirrors slicing adjustments for R4 output |
| igs/imaging-r5/input/fsh/profiles/im-imagingstudy.fsh | Mirrors slicing adjustments for R5 output |
| ig-src/input/fsh/profiles/im-identifiers.fsh | Refines accession/study UID identifier typing to DICOM codings |
| igs/imaging-r4/input/fsh/profiles/im-identifiers.fsh | Same identifier profile updates for R4 |
| igs/imaging-r5/input/fsh/profiles/im-identifiers.fsh | Same identifier profile updates for R5 |
| ig-src/input/fsh/profiles/im-diagnosticreport.liquid.fsh | Adds infoRecipient extension, issued definition, radiationDose ext |
| igs/imaging-r4/input/fsh/profiles/im-diagnosticreport.fsh | Same DiagnosticReport profile updates for R4 |
| ig-src/input/fsh/profiles/im-anatomical-region.fsh | Adds SNOMED copyright insertion |
| igs/imaging-r4/input/fsh/profiles/im-anatomical-region.fsh | Same SNOMED copyright insertion for R4 |
| igs/imaging-r5/input/fsh/profiles/im-anatomical-region.fsh | Same SNOMED copyright insertion for R5 |
| ig-src/input/fsh/profiles/Im-operations.fsh | Changes OperationDefinition name casing |
| igs/imaging-r4/input/fsh/profiles/Im-operations.fsh | Same operation change for R4 |
| igs/imaging-r5/input/fsh/profiles/Im-operations.fsh | Same operation change for R5 |
| ig-src/input/fsh/api/MhdDocumentReference.liquid.fsh | Adds R4 doc version extension + bodySite coding changes |
| igs/imaging-r4/input/fsh/api/MhdDocumentReference.fsh | Same changes for generated R4 |
| igs/imaging-r5/input/fsh/api/MhdDocumentReference.fsh | Adds R4 comments + simplifies bodySite coding constraint |
| ig-src/input/fsh/api/CapabilityStatementResourceAccessProvider.liquid.fsh | Makes IPA instantiates R4-only in liquid |
| igs/imaging-r5/input/fsh/api/CapabilityStatementResourceAccessProvider.fsh | Comments out IPA instantiates line |
| ig-src/input/fsh/alias-extensions.liquid.fsh | Adds alias for DiagnosticReport composition extension |
| igs/imaging-r4/input/fsh/alias-extensions.fsh | Same alias addition for generated R4 |
| ig-src/input/fsh/actors/consumer.fsh | Updates narrative about consumer obligations (has typos) |
| igs/imaging-r4/input/fsh/actors/consumer.fsh | Same consumer narrative update for R4 |
| igs/imaging-r5/input/fsh/actors/consumer.fsh | Same consumer narrative update for R5 |
| ig-src/input/fsh/report-example-semi-structured/* | Adds semi-structured docref/bundle + validator workaround anchor obs |
| igs/imaging-r4/input/fsh/report-example-semi-structured/* | Mirrors semi-structured example additions for R4 output |
| igs/imaging-r5/input/fsh/report-example-semi-structured/* | Mirrors semi-structured example additions for R5 output |
| ig-src/input/images-source/example-structured-findings.liquid.plantuml | Updates key-image links (currently duplicated block) |
| igs/imaging-r4/input/images-source/*.plantuml | Updates diagram links to new artifact pages |
| igs/imaging-r5/input/images-source/*.plantuml | Updates diagram links to new artifact pages |
| igs/imaging-r4/input/images/.~lock.xtehr-model-mapping.tsv# | Adds a LibreOffice lock file (should not be committed) |
| igs/imaging-r5/input/images/.~lock.xtehr-model-mapping.tsv# | Adds a LibreOffice lock file (should not be committed) |
| ig-src/input/images/.~lock.xtehr-model-mapping.tsv# | Adds a LibreOffice lock file (should not be committed) |
| ig-src/README.md | File content replaced with FSH definitions (likely misplaced) |
Comments suppressed due to low confidence (7)
ig-src/input/includes/variable-definitions.md:1
- The R5 branch sets
isR4 = trueandisR5 = false, so R5-specific content will never render. Update the{% else %}branch to setisR4 = falseandisR5 = true.
ig-src/input/includes/variable-definitions.md:1 - These Liquid assignments appear to have multiple syntax errors (unterminated quotes/
%}and missing quotes around markdown links). This will likely break page preprocessing; fix by ensuring each{% assign ... %}line has properly quoted string values and is closed with%}.
ig-src/input/images/.~lock.xtehr-model-mapping.tsv#:1 - This looks like a LibreOffice lock file and should not be committed (contains machine/user-specific paths). Remove it from the repo and add an ignore rule for
.~lock.*#(or the equivalent pattern) to prevent reintroduction.
ig-src/input/fsh/actors/consumer.fsh:1 - Fix typos in the actor documentation to improve readability.
ig-src/input/fsh/actors/consumer.fsh:1 - Fix typos in the actor documentation to improve readability.
ig-src/publication-request.json:1 - There appears to be a missing space in 'ReportFHIR'.
ig-src/input/fsh/profiles/Im-operations.fsh:1 - For an OperationDefinition described as
$document, a capitalizednamemay be inconsistent with common conventions wherenameis a code-like identifier (often lowerCamelCase, e.g.,document). If this value is used by any tooling or referenced elsewhere, consider keepingname = \"document\"and rely ontitlefor display-friendly text.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
@bvdh ready for review/merge |
bvdh
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the multiversion CI-build with the 1.0.0-ballot version for R4 and R5.