Tighten non-GPU multiprocess adapter typing (replace Any with concrete IPC/MQ types)#328
Draft
Copilot wants to merge 3 commits into
Draft
Tighten non-GPU multiprocess adapter typing (replace Any with concrete IPC/MQ types)#328Copilot wants to merge 3 commits into
Any with concrete IPC/MQ types)#328Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Replace Any type annotations with concrete types in adapter_connector
Tighten non-GPU multiprocess adapter typing (replace May 30, 2026
Any with concrete IPC/MQ/GPU format types)
hlin99
requested changes
May 30, 2026
Owner
hlin99
left a comment
There was a problem hiding this comment.
remove lmc_ops.GPUKVFormat changes, we can use Any for lmc_ops.GPUKVFormat, i don't want to import lmc_ops
Author
Addressed in commit 9908844. I removed the |
Copilot
AI
changed the title
Tighten non-GPU multiprocess adapter typing (replace
Tighten non-GPU multiprocess adapter typing (replace May 30, 2026
Any with concrete IPC/MQ/GPU format types)Any with concrete IPC/MQ types)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the non-GPU multiprocess adapter interfaces to use concrete protocol types instead of
Anywhere appropriate, and aligns affected tests with the stricter key contract. The goal is to make the IPC boundary explicitly typed across base and concrete adapters without introducing a dependency onlmc_opsGPU format typing.Adapter base typing hardening (
adapter_connector/base.py)mq_clientnow usesMessageQueueClient.keyparams now useIPCCacheEngineKey(prepare_store,commit_store,prepare_retrieve,commit_retrieve).layout_hintsnow usesLayoutHints | None.gpu_kv_formatremainsAny | None(nolmc_ops.GPUKVFormattyping import).compute_kv_layoutGPU format return element remainsAny.Concrete adapter signature alignment
adapter_connector/shm.py: updatedmq_clientand allkeysignatures toMessageQueueClient/IPCCacheEngineKey.adapter_connector/pickle.py: same signature updates as SHM path.Test key contract update (
test_non_cuda_data_transfer.py)test_non_gpu_context_shm_store_retrieve_flow_with_mocked_mqwith a properIPCCacheEngineKeyinstance (_default_key()), and reused it across prepare/commit store/retrieve calls.Example of the key change pattern:
Original prompt
This pull request was created from Copilot chat.