-
Notifications
You must be signed in to change notification settings - Fork 31
CCD-7242 Sponsor contact details do not show up on the Check Your Answers page #2843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
markdathornehmcts
wants to merge
28
commits into
master
Choose a base branch
from
CCD-7242_testharness
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
91aa71b
CCD-7242 definition spreadsheet test harness added
markdathornehmcts e3057d6
CCD-7242 definition spreadsheet test harness added
markdathornehmcts 4b7928d
CCD-7242 documentation added
markdathornehmcts 8e32c9f
CCD-7242 removed unused logback configuration
markdathornehmcts 0c7b8be
CCD-7242 using Slf4J for logging
markdathornehmcts ce9fbc1
CCD-7242 constants for caseventid, caasetypeid, casefieldid
markdathornehmcts 991d6a9
CCD-7242 remove alternative name lookup for the "casetypeid" and "cas…
markdathornehmcts c2e4e3b
CCD-7242 remove alternative name for accessprofile column
markdathornehmcts 9743508
CCD-7242 remove complexity and findHeaderRow
markdathornehmcts 1b6198f
CCD-7242 deal with null headerRow
markdathornehmcts 2489fe6
CCD-7242 remove alternative header names
markdathornehmcts 708caaf
CCD-7242 remove unused file logback-test.xml
markdathornehmcts cc5e2cc
CCD-7242 code review changes
markdathornehmcts e96d362
CCD-7242 runnable definitionSpreadsheetHarness
markdathornehmcts 56429f1
CCD-7242 remove ambiguous warnings for both jackson version 2 and 3
markdathornehmcts fd5022a
CCD-7242 moved harness to support-tools module
markdathornehmcts f189976
CCD-7242 fix pipeline build
markdathornehmcts edb5ee5
CCD-7242 Moved harness to support-tools module. Add test. Review code
markdathornehmcts 3f7fe8a
CCD-7242 Fix ACR Migration check failure furing pipeline build - hmct…
markdathornehmcts 19c493b
CCD-7242 documentation added
markdathornehmcts b5ea538
CCD-7242 tidy up
markdathornehmcts 5f78cb6
CCD-7242 simplify readSheet method.
markdathornehmcts c512e28
CCD-7242 test excel files now in resources
markdathornehmcts 5138b30
CCD-7242 general get system property error message handling
markdathornehmcts 4c3810d
CCD-7242 new open spreadsheet inputstream method
markdathornehmcts 1ec6d90
Merge branch 'master' into CCD-7242_testharness
markdathornehmcts 0f39ac2
CCD-7242 merge master changes to fix build
markdathornehmcts eb6d824
Merge remote-tracking branch 'origin/CCD-7242_testharness' into CCD-7…
markdathornehmcts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| #!/usr/bin/env bash | ||
| # Runs the definition spreadsheet harness with the provided arguments. | ||
| # | ||
| # Usage: | ||
| # run-definition-spreadsheet-harness.sh <definition-xlsx> <roles> <target-fields> <event-id> | ||
| # | ||
| # <roles> and <target-fields> can be comma separated lists. | ||
| # | ||
| # Example: | ||
| # ./scripts/run-definition-spreadsheet-harness.sh /ccd-appeal-config-preview-pr3017.xlsx caseworker-ia-admofficer isFeePaymentEnabled,sponsorEmailAdminJ,sponsorMobileNumberAdminJ,sponsorAddress editAppealAfterSubmit; | ||
| # | ||
| # Process summary: | ||
| # 1) Reads CaseEventToFields, AuthorisationCaseField, RoleToAccessProfiles from the XLSX. | ||
| # 2) Resolves roles to access profiles. | ||
| # 3) Evaluates read access for each field and matching case type for the event. | ||
| # | ||
| # Exit code: | ||
| # Non-zero on Gradle task failure (invalid input/configuration or non-returned decisions). | ||
| # | ||
| set -euo pipefail | ||
|
|
||
| script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
| repo_root="$(cd "${script_dir}/.." && pwd)" | ||
|
|
||
| if [ "$#" -ne 4 ]; then | ||
| exit 1 | ||
| fi | ||
|
|
||
| definition_file="$1" | ||
| roles="$2" | ||
| target_fields="$3" | ||
| event_id="$4" | ||
|
|
||
| cd "${repo_root}" | ||
|
|
||
| ./gradlew definitionSpreadsheetHarness \ | ||
| -Pdefinition.file="$definition_file" \ | ||
| -Proles="$roles" \ | ||
| -Ptarget.fields="$target_fields" \ | ||
| -Pevent.id="$event_id" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.