CME-942: Create a new endpoint /getCloseCases/{date}#2901
Open
SammiChong wants to merge 11 commits into
Open
Conversation
| public interface DateCaseClosedRepository extends CrudRepository<DateCaseClosedEntity, Long> { | ||
|
|
||
| List<DateCaseClosedEntity> findByStateChangedDateLessThanEqual(LocalDateTime stateChangedDate); | ||
| List<DateCaseClosedEntity> findByStateChangedDateBefore(Date stateChangedDate); |
Contributor
There was a problem hiding this comment.
use LocalDate instead of Date
Contributor
Author
There was a problem hiding this comment.
I think going back to LocalDateTime for the repository is better because DateCaseClosedEntity.stateChangedDate maps to a timestamp and is now LocalDateTime.
| @@ -0,0 +1,56 @@ | |||
| @F-943 | |||
| Feature: F-943: Get closed cases | |||
|
|
|||
Contributor
There was a problem hiding this comment.
rename (F-943 - Get Closed Cases) folder to (CME-943 - Get Closed Cases)
Contributor
Author
There was a problem hiding this comment.
I've renamed it to "F-942 - Get Closed Cases" instead of "CME-943 - Get Closed Cases" since that follows the BEFTA naming pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CME-942
Change description
Does this PR introduce a breaking change? (check one with "x")