Skip to content

CCD-7472: Add BEFTA tests for document filtering against saved case data#2908

Merged
hemantt merged 4 commits into
ccd-7472from
ccd-7472-befta-tests
Jun 12, 2026
Merged

CCD-7472: Add BEFTA tests for document filtering against saved case data#2908
hemantt merged 4 commits into
ccd-7472from
ccd-7472-befta-tests

Conversation

@hemantt

@hemantt hemantt commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Adds two scenarios to F-1003 covering the CDAM/CCD sync fix:

  • S-1045: the about-to-submit callback strips the document supplied in the payload - the document must not be persisted to the case (regression test for the production incident shape)
  • S-1046: the about-to-submit callback echoes the data unchanged - the document must still be persisted (guards the new saved-data filter against over-filtering)

Both use the FT_MasterCaseType documentHashCallback creation event with metadata-scoped dynamic wiremock stubs on the ccd-test-stubs service, following the S-1041 pattern. The CDAM-side assertion (attach not invoked) is covered by CaseDetailsEndpointIT in this PR, as BEFTA cannot observe CDAM calls black-box.

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • the keep-helm label has been added, if the helm release should be persisted after a successful build

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

hemantt added 2 commits June 12, 2026 00:32
Adds two scenarios to F-1003 covering the CDAM/CCD sync fix:
 - S-1045: the about-to-submit callback strips the document supplied in the
   payload - the document must not be persisted to the case (regression test
   for the production incident shape)
 - S-1046: the about-to-submit callback echoes the data unchanged - the
   document must still be persisted (guards the new saved-data filter
   against over-filtering)

Both use the FT_MasterCaseType documentHashCallback creation event with
metadata-scoped dynamic wiremock stubs on the ccd-test-stubs service,
following the S-1041 pattern. The CDAM-side assertion (attach not invoked)
is covered by CaseDetailsEndpointIT in this PR, as BEFTA cannot observe
CDAM calls black-box.

@aktaskaan aktaskaan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hemantt hemantt merged commit d1557b8 into ccd-7472 Jun 12, 2026
5 checks passed
@hemantt hemantt deleted the ccd-7472-befta-tests branch June 12, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants