Open
Conversation
…ndles these when they are mp4.
…esulting in a DOM error
An iOS hack should only exist on iOS
…uted getter/setters
… the SoundJS combined file.
There is a small typo in examples/Game/Ship.js, examples/Game/SpaceRock.js. Should read `amount` rather than `ammount`.
docs: Fix simple typo, ammount -> amount
The XHR test was giving an error - what do you know, the try catch does not work anymore. So adjusted the test to just assume it is not XHR if local. Also we are getting a warning to not play sounds before interacting. We are not playing but are testing. So follow up with a warning that the sounds are ready to play to make whoever is looking at the warnings feel better.
sboobalans
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull code from the sound js master