Skip to content

bump GetEmbedding timeout #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexvpickering merged 3 commits into from
May 22, 2026
Merged

bump GetEmbedding timeout #1061

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2962a1d
bump GetEmbedding timeout
alexvpickering May 21, 2026
fa85c49
sync marker plot changes in data-processing
alexvpickering May 22, 2026
f96b01c
undo timeout increase
alexvpickering May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 48 additions & 15 deletions src/components/data-processing/ConfigureEmbedding/ConfigureEmbedding.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,7 @@ const ConfigureEmbedding = (props) => {
},
{
panelTitle: 'Markers',
controls: [{
name: 'markers',
props: { showShapeType: false },
}],
controls: ['markers'],
},
{
panelTitle: 'Legend',
Expand Down Expand Up @@ -116,10 +113,7 @@ const ConfigureEmbedding = (props) => {
},
{
panelTitle: 'Markers',
controls: [{
name: 'markers',
props: { showShapeType: false },
}],
controls: ['markers'],
},
{
panelTitle: 'Legend',
Expand All @@ -145,10 +139,7 @@ const ConfigureEmbedding = (props) => {
},
{
panelTitle: 'Markers',
controls: [{
name: 'markers',
props: { showShapeType: false },
}],
controls: ['markers'],
},
{
panelTitle: 'Legend',
Expand Down Expand Up @@ -424,6 +415,30 @@ const ConfigureEmbedding = (props) => {
}
}, [currentPlot]);

// When switching between embedding plots, sync marker settings across all embedding plots
useEffect(() => {
if (plotType !== 'embedding' || !selectedConfig?.marker) return;

// Get all embedding plot UUIDs
const embeddingPlotUuids = [];
Object.values(plots).forEach(({ subPlots }) => {
if (subPlots.embedding) {
embeddingPlotUuids.push(subPlots.embedding.plotUuid);
}
});

// Apply current plot's marker settings to all other embedding plots
embeddingPlotUuids.forEach((plotUuid) => {
if (plotUuid !== activePlotUuid) {
const otherPlotConfig = plotConfigs[plotUuid];
if (otherPlotConfig &&
JSON.stringify(otherPlotConfig.marker) !== JSON.stringify(selectedConfig.marker)) {
dispatch(updatePlotConfig(plotUuid, { marker: selectedConfig.marker }));
}
}
});
}, [activePlotUuid, plotType, selectedConfig?.marker]);

useEffect(() => {
if (!selectedConfig) {
return;
Expand All @@ -432,14 +447,32 @@ const ConfigureEmbedding = (props) => {
const plotActions = {
export: true,
};

if (cellSets.accessible && selectedConfig) {
setPlot(currentPlot.plot(selectedConfig, plotActions));
}
}, [selectedConfig, cellSets, cellMeta]);
}, [selectedConfig, cellSets, cellMeta, plotType]);

const updatePlotWithChanges = (obj) => {
dispatch(updatePlotConfig(currentPlot.plotUuid, obj));
debounceSave(currentPlot.plotUuid);
// Get all embedding plot UUIDs
const embeddingPlotUuids = [];
Object.values(plots).forEach(({ subPlots }) => {
if (subPlots.embedding) {
embeddingPlotUuids.push(subPlots.embedding.plotUuid);
}
});

// If updating marker settings on an embedding plot, apply to all embedding plots
if (plotType === 'embedding' && obj.marker) {
embeddingPlotUuids.forEach((plotUuid) => {
dispatch(updatePlotConfig(plotUuid, { marker: obj.marker }));
debounceSave(plotUuid);
});
} else {
// For non-marker changes, only update current plot
dispatch(updatePlotConfig(currentPlot.plotUuid, obj));
debounceSave(currentPlot.plotUuid);
}
};

const isConfigEqual = (currentConfig, initialConfig) => {
Expand Down
Loading