Skip to content

PR4/15: pic-sure-gateway (Spring Cloud Gateway + DB-free auth/audit)#263

Merged
Gcolon021 merged 20 commits into
api_rewrite_stablefrom
psar/04-gateway
Jul 16, 2026
Merged

PR4/15: pic-sure-gateway (Spring Cloud Gateway + DB-free auth/audit)#263
Gcolon021 merged 20 commits into
api_rewrite_stablefrom
psar/04-gateway

Conversation

@Gcolon021

@Gcolon021 Gcolon021 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

The gateway: SCG routing, the DB-free auth/audit filter chain, system health composition, docker-compose/Dockerfile. Talks to backend services over HTTP only (no compile deps). 100 tests. Split into 5 review-friendly commits.

📚 Stacked PR series (1–7) — part of decomposing the pic_sure_api_rewrite monorepo rewrite into sequential, independently-green PRs. Review and merge bottom-up (this PR's base is the PR below it; GitHub auto-retargets to main as each merges). Every PR builds + tests green on its own under JDK 25.

JamesPeck and others added 9 commits March 3, 2026 12:35
@JamesPeck
Initial Commit
141639a
@JamesPeck
Refactor LoggingClient to use Sender interface (#1)
038857b 
* Refactor LoggingClient to use Sender interface

* Refactor LoggingClient to use config in JdkHttpSender

* Add Sender interface for logging functionality

* Implement JdkHttpSender for asynchronous HTTP requests

* Add NoOpSender class for logging

* Refactor LoggingClientTest for clarity and safety

* Refactor test method signatures for consistency
@JamesPeck
Setup CI (#2)
8d04f2f 
* add package wf

* Format

* Add wf files

Update README.md
@JamesPeck
Add @AuditEvent annotation for declarative endpoint categorization
b4fec7f
@JamesPeck
Update LoggingClientFactory.java
36d02dd
@JamesPeck
Handle session ids as first class
2f3da1a
@JamesPeck
format
a26baf4
@ramari16
Initial commit
a252498
@ramari16
ALS-11850: Initial commit. Move common HPDS and PIC-SURE code to comm…
8fc524f 
…on repo (#1)
@coderabbitai

coderabbitai Bot commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 14e4358b-aaad-4756-b952-7d557a792a68

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch psar/04-gateway

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Gcolon021 Gcolon021 changed the title PR4/7: pic-sure-gateway (Spring Cloud Gateway + DB-free auth/audit) PR4/14: pic-sure-gateway (Spring Cloud Gateway + DB-free auth/audit) Jul 11, 2026
@Gcolon021 Gcolon021 self-assigned this Jul 14, 2026
@Gcolon021 Gcolon021 added the enhancement New feature or request label Jul 14, 2026
@Gcolon021
Gcolon021 marked this pull request as ready for review July 14, 2026 15:26
Gcolon021 added 10 commits July 14, 2026 13:46
@Gcolon021
build: establish monorepo aggregator + pic-sure-bom scaffold
b072328
@Gcolon021
Add 'libs/pic-sure-logging-client/' from commit 'a26baf432f263b8a7efd…
5774c67 
…60aecdde1f6e6f088fb6'

git-subtree-dir: libs/pic-sure-logging-client
git-subtree-mainline: b072328
git-subtree-split: a26baf4
@Gcolon021
Add 'libs/pic-sure-commons/' from commit '8fc524f5c8a995f0b14a245c73a…
1a9c04d 
…f6d9ca0ac54e9'

git-subtree-dir: libs/pic-sure-commons
git-subtree-mainline: 5774c67
git-subtree-split: 8fc524f
@Gcolon021
build: vendor pic-sure-commons + pic-sure-logging-client (subtree imp…
8f3d502 
…ort, pre-v1v3 state)
@Gcolon021
feat(spring-commons): shared exception/audit/identity/actuator-securi…
6bae834 
…ty library
@Gcolon021
feat(gateway): Spring Cloud Gateway module scaffold, config, docker
a749e4d
@Gcolon021
feat(gateway): DB-free auth/audit filter chain + security config
67bf75b
@Gcolon021
feat(gateway): route definitions + system health composition
d8de03a
@Gcolon021
test(gateway): route, filter-chain, and health tests
071d456
@Gcolon021
build(gateway): register module in aggregator
253be68
@Gcolon021
Gcolon021 force-pushed the psar/03-spring-commons branch from 9ee2d71 to 6bae834 Compare July 14, 2026 18:09
@Gcolon021 Gcolon021 changed the title PR4/14: pic-sure-gateway (Spring Cloud Gateway + DB-free auth/audit) PR4/15: pic-sure-gateway (Spring Cloud Gateway + DB-free auth/audit) Jul 14, 2026
ramari16
ramari16 reviewed Jul 16, 2026
View reviewed changes
Comment thread services/pic-sure-gateway/README.md

@ramari16 ramari16 Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ramari16
ramari16 reviewed Jul 16, 2026
View reviewed changes
Comment thread ...e-gateway/src/main/java/edu/harvard/hms/dbmi/avillach/gateway/filter/BodyMutationFilter.java
* present) and building the mutated body throws, the request is rejected with a 500 rather than forwarded with the original, un-swapped
* body.
*/
public class BodyMutationFilter extends OncePerRequestFilter {

@ramari16 ramari16 Jul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that this is isolated now, so much nicer than the JWT filter

@Gcolon021
Gcolon021 changed the base branch from psar/03-spring-commons to api_rewrite_stable July 16, 2026 18:14
@Gcolon021
Gcolon021 merged commit 750f252 into api_rewrite_stable Jul 16, 2026
4 checks passed
@Gcolon021
Gcolon021 deleted the psar/04-gateway branch July 16, 2026 18:50
Gcolon021 added a commit that referenced this pull request Jul 17, 2026
@Gcolon021
PR4/15: pic-sure-gateway (Spring Cloud Gateway + DB-free auth/audit) (#…
7fe2994 
…263)
@Gcolon021 Gcolon021 mentioned this pull request Jul 20, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramari16 ramari16 ramari16 approved these changes
@JamesPeck JamesPeck Awaiting requested review from JamesPeck
@srpiatt srpiatt Awaiting requested review from srpiatt

Assignees

@Gcolon021 Gcolon021

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gcolon021 @ramari16 @JamesPeck