PR5/15: pic-sure-operations-service#264
Conversation
* Refactor LoggingClient to use Sender interface * Refactor LoggingClient to use config in JdkHttpSender * Add Sender interface for logging functionality * Implement JdkHttpSender for asynchronous HTTP requests * Add NoOpSender class for logging * Refactor LoggingClientTest for clarity and safety * Refactor test method signatures for consistency
* add package wf * Format * Add wf files Update README.md
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Gcolon021
changed the title
| } | ||
| } | ||
|
|
||
| private static PicsureException notFound(UUID id) { |
There was a problem hiding this comment.
I think these should be moved out to class that can be reused.
| */ | ||
| @RestController | ||
| @RequestMapping("/internal/queries") | ||
| public class InternalQueryController { |
There was a problem hiding this comment.
Intended to not be publicly available. Request from the hpds-query-service are sent here.
| * before this method runs, so this is a defensive guard against a gateway that authenticated the caller (sent {@code X-User-Id}) but | ||
| * omitted {@code X-User-Email} -- not the primary auth gate. | ||
| */ | ||
| private String requireEmail(GatewayUser user) { |
There was a problem hiding this comment.
belongs in the service layer
| return repo.findByName(identifier).stream().findFirst(); | ||
| } | ||
|
|
||
| private static PicsureException notFound(String identifier) { |
There was a problem hiding this comment.
Move to shared dedicate class
…ort, pre-v1v3 state)
…tities and repositories
…nd controller surfaces
…ataset/internal-query surfaces
c907cbb to
253be68
Compare
2d8a648 to
0fe9f95
Compare
Gcolon021
changed the title
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 participants
DB-backed config/dataset/internal-query API and the migrated
pic-sure-api-dataentities. Depends on spring-commons; tests use embedded H2. 106 tests.📚 Stacked PR series (1–7) — part of decomposing the
pic_sure_api_rewritemonorepo rewrite into sequential, independently-green PRs. Review and merge bottom-up (this PR's base is the PR below it; GitHub auto-retargets tomainas each merges). Every PR builds + tests green on its own under JDK 25.