PR11/15: picsure-dictionary (3 modules) — adopt parent + BOM (Java 25)#270
Open
Gcolon021 wants to merge 2 commits into
Open
PR11/15: picsure-dictionary (3 modules) — adopt parent + BOM (Java 25)#270Gcolon021 wants to merge 2 commits into
Gcolon021 wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Gcolon021
force-pushed
the
psar/10-pic-sure-services
branch
from
July 14, 2026 18:09
52fc3c7 to
5c4ef60
Compare
Gcolon021
force-pushed
the
psar/11-dictionary
branch
from
July 14, 2026 18:09
ef0fdc4 to
0e1567d
Compare
Gcolon021
changed the title
…C5, drop org.json/HC4; fix never-runnable weights tests Carved from pic_sure_api_mono_repo @ carve-source. Adds the three modules to the reactor and a reactor-aware path-filtered CI workflow.
Gcolon021
force-pushed
the
psar/10-pic-sure-services
branch
from
July 14, 2026 18:12
5c4ef60 to
d942940
Compare
Gcolon021
force-pushed
the
psar/11-dictionary
branch
from
July 14, 2026 18:12
0e1567d to
0cb4706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the dictionary service (dictionary, aggregate, dictionaryweights) onto the pic-sure-api
reactor: parent+BOM (versionless deps), Java 25, RestClient over Apache HttpClient 5, drops
org.json and HttpClient 4, and fixes the never-runnable weights tests. Adds a reactor-aware
path-filtered CI workflow (the old standalone JDK-21 lint job is dropped; formatting is
root-owned). Diff vs PR10 = exactly the refactor.
Two commits: commit 1 is the refactor (byte-identical to the frozen carve-source tree);
commit 2 is mechanical spotless normalization by the repo formatter (line re-wrapping only).
Review commit 1 for substance.
Reconciliation with psar libs: none.
Verified: full-reactor
mvn -T1C clean verifygreen from the root; service tree byte-identical tocarve-source; gitleaks clean.