PR12/15: pic-sure-logging — adopt parent + BOM (Java 25, stays Javalin)#271
Open
Gcolon021 wants to merge 2 commits into
Open
PR12/15: pic-sure-logging — adopt parent + BOM (Java 25, stays Javalin)#271Gcolon021 wants to merge 2 commits into
Gcolon021 wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Gcolon021
force-pushed
the
psar/11-dictionary
branch
from
July 14, 2026 18:09
ef0fdc4 to
0e1567d
Compare
Gcolon021
force-pushed
the
psar/12-logging
branch
from
July 14, 2026 18:09
c2a6dce to
efbbde3
Compare
Gcolon021
changed the title
… pin against Spring-BOM Jetty 12) Carved from pic_sure_api_mono_repo @ carve-source. Adds the module to the reactor, the logstash-logback-encoder BOM pin, and a reactor-aware path-filtered CI workflow.
Gcolon021
force-pushed
the
psar/11-dictionary
branch
from
July 14, 2026 18:12
0e1567d to
0cb4706
Compare
Gcolon021
force-pushed
the
psar/12-logging
branch
from
July 14, 2026 18:12
efbbde3 to
454b21a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the logging service onto the pic-sure-api reactor: parent+BOM (versionless deps), Java 25.
The service stays on Javalin, with a Jetty 11 pin against the Spring-BOM's Jetty 12 (declared in
the service pom). Adds the logstash-logback-encoder BOM pin and a reactor-aware path-filtered CI
workflow. Diff vs PR11 = exactly the refactor.
Two commits: commit 1 is the refactor (byte-identical to the frozen carve-source tree); commit 2 is mechanical spotless normalization by the repo formatter (line re-wrapping only). Review commit 1 for substance.
Reconciliation with psar libs: none.
Verified: full-reactor
mvn -T1C clean verifygreen from the root; service tree byte-identical tocarve-source; gitleaks clean.