PR15/15: build gates — enforcer convergence, Boot 3.5.16, wrapper, formatter 4.35, secrets CI, Dependabot#274
Open
Gcolon021 wants to merge 48 commits into
Open
PR15/15: build gates — enforcer convergence, Boot 3.5.16, wrapper, formatter 4.35, secrets CI, Dependabot#274Gcolon021 wants to merge 48 commits into
Gcolon021 wants to merge 48 commits into
Conversation
…ort, pre-v1v3 state)
…tities and repositories
…nd controller surfaces
…ataset/internal-query surfaces
Add QueryTranslator support for translating legacy v1 query shapes to the v3 query model, plus UntranslatableQueryException for queries that cannot be represented in v3.
…faces Scaffold the hpds-query-service Spring Boot application: v3 query controller/service, variable search controller/service, and the supporting HPDS/operations HTTP clients, gateway auth wiring, and config/error/health plumbing.
Add the count/cross-count aggregate controllers, backend client, and obfuscation/visualization-formatting services that sit on top of the HPDS aggregate query endpoints.
…arch/aggregate surfaces
…/pic-sure-visualization-service
…/pic-sure-auth-microapp
…pi-model replaces resource-api Carved from pic_sure_api_mono_repo @ carve-source. Adds the module to the reactor, the httpclient5 BOM pin, and a reactor-aware path-filtered CI workflow.
…, Java 25, RestClient+HC5; api-model replaces jitpack deps; runtime-only Dockerfiles Carved from pic_sure_api_mono_repo @ carve-source. Adds both modules to the reactor and a reactor-aware path-filtered CI workflow.
…C5, drop org.json/HC4; fix never-runnable weights tests Carved from pic_sure_api_mono_repo @ carve-source. Adds the three modules to the reactor and a reactor-aware path-filtered CI workflow.
… pin against Spring-BOM Jetty 12) Carved from pic_sure_api_mono_repo @ carve-source. Adds the module to the reactor, the logstash-logback-encoder BOM pin, and a reactor-aware path-filtered CI workflow.
…it4 + mismatched Jackson pins Carved from pic_sure_api_mono_repo @ carve-source. Adds the module to the reactor, the okio convergence pin, and a reactor-aware path-filtered CI workflow.
…red per spec) Carved from pic_sure_api_mono_repo @ carve-source. Adds the aggregator module to the reactor and a reactor-aware path-filtered CI workflow. HPDS-scoped dependency pins live in the service's own poms.
Ported from the consolidation line: bans commons-httpclient and org.json transitively, junit:junit and okhttp as direct declarations, and turns on dependencyConvergence reactor-wide. Passes with zero new version pins.
Aligns the reactor with the version the carved services were developed and tested against. Convergence gates stay green.
Pins the build tool for contributors and CI; .gitignore already whitelists the wrapper jar.
All seven workflows now use the pinned wrapper; the full-reactor catch-all gets the same setup-java maven cache the per-service workflows already had.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Gcolon021
force-pushed
the
psar/14-hpds
branch
2 times, most recently
from
July 14, 2026 18:12
f31c1d2 to
bafd282
Compare
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 34518621 | Triggered | Generic High Entropy Secret | 8d013b0 | services/pic-sure-hpds-query-service/src/test/java/edu/harvard/hms/dbmi/avillach/query/hpds/HpdsBackendSelectorTest.java | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices. AWS Best Practice
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
4.26 cannot parse Java 21 guarded-pattern switches (crashed on psama's AccessRuleService - the documented PR #272 exception). 4.35 parses the whole reactor, so incremental spotless:apply works on every module. The reactor-wide normalization has been dropped per project preference (format incrementally, only files a developer is already changing - no mass reformat). RASPassPortServiceTest.java is kept formatted solely to preserve the two '// gitleaks:allow' annotations on its synthetic JWTs, which keep the secrets-scan gate green; .gitleaksignore is only a scaffold.
…e scaffold Persists the carve's manual secrets gate: every PR is scanned in CI with a checksum-pinned gitleaks 8.30.1, and an optional pre-push hook mirrors the existing pre-commit convention (NO_VERIFY escape hatch, .gitleaksignore for documented false positives).
…t stdin Final-review hardening: gitleaks inside the while-read loop shared the hook's stdin; a stdin-consuming invocation would swallow the remaining ref lines. Redirecting from /dev/null makes the loop robust regardless of gitleaks' behavior.
Gcolon021
force-pushed
the
psar/15-build-gates
branch
from
July 16, 2026 14:44
6d7092f to
9db9d34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up governance PR closing out the consolidation stack — one commit per concern:
dependencyConvergence+ duplicate-responsibility bans (transitive: commons-httpclient, org.json; direct: junit:junit, okhttp). Passes reactor-wide with zero new pins. HC4 ban stays deferred (FO-1, HPDS etl)../mvnw; the catch-all workflow gains dependency caching.spotless:checkis now green on every module. Two synthetic test JWTs inRASPassPortServiceTest.javagained// gitleaks:allowtrailing comments (repo false-positive convention) when the reformat re-touched their lines..gitleaksignorescaffold.dependabot.yml(maven reactor + github-actions). Old-layout Dependabot PRs Bump org.apache.commons:commons-lang3 from 3.7 to 3.18.0 #231/Bump org.apache.logging.log4j:log4j-core from 2.18.0 to 2.25.4 #247/Bump com.fasterxml.jackson.core:jackson-databind from 2.18.6 to 2.22.0 #251 to be closed after the stack merges.Verified: full-reactor
./mvnw -T1C clean verifygreen at tip; reactor-widespotless:checkgreen; gitleaks clean over the whole range; only the style commit touches service trees, Java files only.