docs: add authentication security patterns to DEVELOPMENT.md#192
Merged
hoiekim merged 1 commit intohoiekim:mainfrom Mar 26, 2026
Merged
docs: add authentication security patterns to DEVELOPMENT.md#192hoiekim merged 1 commit intohoiekim:mainfrom
hoiekim merged 1 commit intohoiekim:mainfrom
Conversation
Contributor
Author
Self-ReviewDiscussion thread status:
Checked:
E2E Testing:
Issues found:
Confidence: High |
Contributor
Author
Self-ReviewDiscussion thread status:
Checked:
E2E Testing:
Issues found:
Confidence: High |
Document anti-timing-attack pattern (dummy bcrypt hash) and generic error messages for login routes. Based on patterns from PR hoiekim#136.
1299fd3 to
dca3cbb
Compare
hoiekim
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents anti-timing-attack patterns for login routes, based on patterns established in PR #136.
Added
Authentication Security section covering:
e2e Testing
Documentation-only change. Verified DEVELOPMENT.md renders correctly and content is accurate against the actual implementation in
src/server/routes/users/post-login.ts.