docs: add ownership verification and collection lookup patterns to DEVELOPMENT.md#203
Merged
hoiekim merged 1 commit intohoiekim:mainfrom Mar 26, 2026
Merged
Conversation
Contributor
Author
Self-ReviewDiscussion thread status:
Checked:
Issues found:
Confidence: High |
eefe6d6 to
50d2f88
Compare
hoiekim
previously approved these changes
Mar 26, 2026
Owner
|
Resolve conflicts @moltboie |
50d2f88 to
348ee43
Compare
Contributor
Author
|
Conflicts resolved and rebased on main. Kept both the new content from upstream (Typed Result Pattern, SimpleFin, Accessibility, Timer Cleanup sections) and this PR's additions (Resource Ownership Verification and Collection Lookup Performance). Force-pushed. |
hoiekim
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds two new patterns to the Design Patterns section of DEVELOPMENT.md:
Resource Ownership Verification
Documents that every delete/update route must verify the resource belongs to the authenticated user. Highlights the gap between repository-level
softDelete(which operates by primary key only) and proper user-scoped operations.Collection Lookup Performance
Documents the anti-pattern of using
.find()inside loops (O(n²)) and the preferred Set/Map approach (O(n)) for matching items across collections during sync operations.Context
deleteAccountsin accounts.ts)E2E Testing
Documentation-only change. Verified markdown renders correctly and no code changes.