chore: fix misspelled file names and route function names#204
Merged
hoiekim merged 3 commits intohoiekim:mainfrom Mar 26, 2026
Merged
chore: fix misspelled file names and route function names#204hoiekim merged 3 commits intohoiekim:mainfrom
hoiekim merged 3 commits intohoiekim:mainfrom
Conversation
Contributor
Author
Self-ReviewDiscussion thread status:
Checked:
E2E Testing:
Issues found:
Confidence: High |
Contributor
Author
CI FixTest failure: Fixed in 059e4c7: updated import to |
moltboie
force-pushed
the
chore/fix-typos-201
branch
from
059e4c7 to
247a0fb
Compare
Owner
|
@moltboie CI stil fails. Fix it |
- Rename Calcuations.ts → Calculations.ts - Rename Calcuations.holdings.test.ts → Calculations.holdings.test.ts - Update index.ts and holdings.ts import to use correct spelling - Rename postTrasactionRoute → postTransactionRoute - Rename postSplitTrasactionRoute → postSplitTransactionRoute - Rename postInvestmentTrasactionRoute → postInvestmentTransactionRoute Closes hoiekim#201
…ename Missed misspelled import in holdings.test.ts (had Calcuations, not Calculations). This was causing a CI module-not-found error.
moltboie
force-pushed
the
chore/fix-typos-201
branch
from
247a0fb to
bd50d9f
Compare
Contributor
Author
|
Fixed. The CI failure was a missed import in Note: there are 12 pre-existing test failures in |
hoiekim
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes typos in file names and exported route function names that hurt code discoverability.
Changes
File renames
Calcuations.ts→Calculations.tsCalcuations.holdings.test.ts→Calculations.holdings.test.tsImport updates
src/client/lib/models/index.ts: barrel re-export updatedsrc/client/lib/hooks/calculation/holdings.ts: direct import updatedRoute export renames
postTrasactionRoute→postTransactionRoutepostSplitTrasactionRoute→postSplitTransactionRoutepostInvestmentTrasactionRoute→postInvestmentTransactionRouteNo runtime behavior changes — these are internal names only. The route registration in
start.tsusesObject.values(routes)so renamed exports are unaffected.Testing
bun run buildpasses ✅Closes #201