fix: handle empty capacities array to prevent app crash#215
Closed
moltboie wants to merge 1 commit intohoiekim:mainfrom
Closed
fix: handle empty capacities array to prevent app crash#215moltboie wants to merge 1 commit intohoiekim:mainfrom
moltboie wants to merge 1 commit intohoiekim:mainfrom
Conversation
- Add defensive return in getActiveCapacity when capacities is empty - Server-side: createBudget/Section/Category now provide a default capacity with month=0 when none is specified Closes hoiekim#211
19ee0b1 to
86d1fb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
TypeError: Cannot read properties of undefined (reading 'month')crash that occurs when a budget/section/category has an emptycapacitiesarray.Root Cause
Two budgets in the DB have
capacities: []. WhengetActiveCapacity()is called:sorted.find(...)returnsundefined(empty array)sorted[sorted.length - 1]evaluates tosorted[-1]→undefinedcapacity[interval](e.g.,capacity['month']) throws onundefinedThis crashes the entire app — the error boundary catches it but there's no recovery.
Fix
Client (
BudgetFamily.ts):getActiveCapacity()now returns a defaultnew Capacity()(month=0) when capacities is emptyServer (
budgets.ts):createBudget,createSection, andcreateCategorynow provide a default capacity ({month: 0, capacity_id: ...}) when none is specified, preventing empty arrays from being storedTesting
tsc --noEmit)Closes #211