Skip to content

docs: add entity ID preservation and anti-enumeration patterns#219

Merged
hoiekim merged 1 commit intohoiekim:mainfrom
moltboie:docs/dev-md-entity-sync-cicd
Mar 27, 2026
Merged

docs: add entity ID preservation and anti-enumeration patterns#219
hoiekim merged 1 commit intohoiekim:mainfrom
moltboie:docs/dev-md-entity-sync-cicd

Conversation

@moltboie
Copy link
Copy Markdown
Contributor

Add two patterns to DEVELOPMENT.md extracted from recent merged PRs:

Entity ID Preservation During Sync

From PR #134 — when cloning entities for sync, capture original references before mutation to avoid lookup failures with new UUIDs.

Authentication: Anti-Enumeration

From PR #136 — generic error messages and constant-time dummy bcrypt comparison to prevent username enumeration and timing attacks.

E2E Testing

Documentation-only change. Verified markdown renders correctly.

Copy link
Copy Markdown
Contributor Author

@moltboie moltboie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-Review

Discussion thread status:

  • No prior thread.

Checked:

  • Logic — Documents two patterns: (1) Entity ID preservation during sync — capture original IDs before cloning; (2) Anti-enumeration via constant-time bcrypt dummy compare and generic error messages.
  • Types — Docs only.
  • Quality — Good examples with explicit bad/good contrast. References specific PRs (#134, #136) for traceability.
  • Maintainability — Self-contained patterns. Clear enough to follow without looking up the referenced PRs.
  • Security — Anti-enumeration section is particularly valuable: generic error messages + dummy bcrypt compare is the correct defense against user enumeration via timing.
  • Tests — N/A.
  • Blockers — None.

Issues found:

  • None.

Confidence: High

Patterns extracted from recent merged PRs:
- Entity ID preservation during sync (PR hoiekim#134): capture original
  references before cloning to avoid lookup failures
- Authentication anti-enumeration (PR hoiekim#136): generic error messages
  and constant-time dummy bcrypt for timing attack prevention
@hoiekim hoiekim merged commit f0f018f into hoiekim:main Mar 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants