ci: upgrade GitHub Actions versions and require CI before deployment#221
Merged
hoiekim merged 1 commit intohoiekim:mainfrom Mar 30, 2026
Merged
Conversation
moltboie
commented
Mar 15, 2026
Contributor
Author
moltboie
left a comment
moltboie
left a comment
There was a problem hiding this comment.
Self-Review
Discussion thread status:
- No prior thread.
Checked:
- Logic — CD now gates on CI success via
workflow_run. Correct: CI must pass before deployment triggers.check-secretsjob guards against missing secrets gracefully. - Types — YAML only. No type concerns.
- Quality — Clean upgrade: checkout@v3→v4, setup-bun@v1→v2, buildx@v2→v3, login@v2→v3, build-push@v3→v6. All to current major versions.
- Maintainability — Standard CI/CD pattern.
workflow_run+head_shacheckout is the correct pattern for secrets-enabled deployments triggered by CI. - Security — Using
ref: github.event.workflow_run.head_shais correct forworkflow_runtriggers — ensures the right commit is checked out. Secrets are only exposed in the base repo context (not forks), which is the safe behavior. - Tests — N/A for CI config.
- Blockers — None.
E2E Testing:
- Merge to main will trigger CI then CD automatically.
Issues found:
- None.
Confidence: High
moltboie
force-pushed
the
chore/ci-cd-action-upgrades
branch
from
81270b3 to
46fa435
Compare
hoiekim
requested changes
Mar 27, 2026
moltboie
force-pushed
the
chore/ci-cd-action-upgrades
branch
3 times, most recently
from
95e8537 to
bddefc9
Compare
Contributor
Author
|
Rebased on main. |
hoiekim
requested changes
Mar 28, 2026
Contributor
Author
|
Rebased on main. |
moltboie
force-pushed
the
chore/ci-cd-action-upgrades
branch
2 times, most recently
from
d3083bd to
5661da9
Compare
- checkout@v3 → @v4 - setup-bun@v1 → @v2 - setup-buildx-action@v2 → @V3 - login-action@v2 → @V3 - build-push-action@v3 → @v6 Remove push:branches trigger from CI — redundant since CD already runs all checks on push to main. Closes hoiekim#216 Closes hoiekim#218
moltboie
force-pushed
the
chore/ci-cd-action-upgrades
branch
from
5661da9 to
6976482
Compare
hoiekim
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Action version upgrades (Closes #216)
actions/checkout@v3→@v4(eliminates Node 16 EOL warnings)oven-sh/setup-bun@v1→@v2docker/setup-buildx-action@v2→@v3docker/login-action@v2→@v3docker/build-push-action@v3→@v6CD now requires CI to pass (Closes #218)
Changed CD trigger from
push: branches: [main]toworkflow_runon CI:conclusion == 'success')push: branches: [main](needed to fire the workflow_run event for CD)workflow_run.head_shafor Docker image checkout/taggingBefore/After
Before: Every push to main deployed immediately — CI could be failing.
After: Deploy only happens after CI tests + build pass on that commit.
Testing