Repository navigation
Support optional people properties in Kotlin generator - #39
Merged
Merged
Conversation
AnalyticsProperty.innerValue is now Any? and optional special properties are read with value?.key instead of value.key, matching how optional event properties are already handled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Make the existing wear_platform entry optional instead of adding new entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Also syncs the csv dependency in Gemfile.lock with the gemspec. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Nullable native and non-null special-property branches need direct test coverage.
1 open finding
What changed in this PR
Adds nullable people-property support to the Kotlin generator.
Changes:
- Generates nullable values and safe enum-key access.
- Updates generator coverage and release metadata.
- Synchronizes the CSV dependency constraint.
| File | Description |
|---|---|
lib/evva/kotlin_generator.rb |
Generates appropriate value accessors. |
lib/evva/templates/kotlin/people_properties.kt |
Allows nullable property values. |
spec/lib/evva/kotlin_generator_spec.rb |
Covers nullable special properties. |
lib/evva/version.rb |
Bumps the release to 0.10.0. |
Gemfile.lock |
Synchronizes version and CSV constraints. |
changelog.md |
Documents nullable Kotlin support. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Releases are cut outside of feature PRs. The changelog entry stays under Unreleased, and Gemfile.lock keeps the csv (~> 3.0) sync with the gemspec. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nunocruz19
marked this pull request as ready for review
October 13, 2026 11:18
Adds a non-null enum property (value.key) and makes rounds_with_wear a nullable native type (value), so every value-fetching path in the people properties generator is exercised. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mrstif
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AnalyticsProperty.innerValueis nowAny?instead ofAny, so people properties can carry null values.WearableAppPlatform?) are generated asinnerValue = value?.keyinstead ofvalue.key, which did not compile for nullable types. This matches how optional event properties are already handled.Long?) keepinnerValue = value.Generated output example
Notes
csv (~> 3.0)dependency inGemfile.lockwith the gemspec, which the 0.9.0 bump missed.Test plan
kotlin_generator_spec.rb:wear_platformis now optional (WearableAppPlatform?) and generatesinnerValue = value?.keybundle exec rspec: 121 examples, 0 failures🤖 Generated with Claude Code